Detecting if an element is found inside a container
$begingroup$
I just wrote this template to detect if a given element is found inside a container:
template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)
{
for (; begin != end; ++begin)
{
if (*begin == object)
{
return true;
}
}
return false;
}
Which then would be called for examples as:
bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);
This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.
c++ beginner template
asked 7 hours ago
Daniel DuqueDaniel Duque
485
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I just wrote this template to detect if a given element is found inside a container:
template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)
{
for (; begin != end; ++begin)
{
if (*begin == object)
{
return true;
}
}
return false;
}
Which then would be called for examples as:
bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);
This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.
c++ beginner template
asked 7 hours ago
Daniel DuqueDaniel Duque
485
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
add a comment |
$begingroup$
I just wrote this template to detect if a given element is found inside a container:
template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)
{
for (; begin != end; ++begin)
{
if (*begin == object)
{
return true;
}
}
return false;
}
Which then would be called for examples as:
bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);
This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.
c++ beginner template
asked 7 hours ago
Daniel DuqueDaniel Duque
485
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
$endgroup$
I just wrote this template to detect if a given element is found inside a container:
template <typename Iterator> bool is_contained(Iterator begin, Iterator end, decltype(*begin) object)
{
for (; begin != end; ++begin)
{
if (*begin == object)
{
return true;
}
}
return false;
}
Which then would be called for examples as:
bool test = is_contained<decltype(container.begin())>(container.begin(), container.end(), anything);
This works fine, but I believe it is not so readable. I am also new to using decltype which makes me wonder if this would crash, and somehow I wont be calling the template correctly. Any feedback is highly appreciated.
c++ beginner template
c++ beginner template
asked 7 hours ago
Daniel DuqueDaniel Duque
485
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 hours ago
Daniel DuqueDaniel Duque
485
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 hours ago
Daniel DuqueDaniel Duque
485
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 7 hours ago
Daniel DuqueDaniel Duque
485
asked 7 hours ago
Daniel DuqueDaniel Duque
485
485
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Daniel Duque is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
2 Answers
2
active
oldest
votes
$begingroup$
Note that for functions the compiler will detect the template types based on the parameters.
So you can simply write:
bool test = is_contained(container.begin(), container.end(), anything);
I don't particularly like the use of decltype in your function. I would simply make it another template parameter.
template <typename Iterator, typename Value>
bool is_contained(Iterator begin, Iterator end, Value const& object);
Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).
answered 7 hours ago
Martin YorkMartin York
74k488271
$endgroup$
add a comment |
$begingroup$
Do you want to test whether an element is in a container, or an iterator-range?
- The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.
- The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.
Constraining the needle to the type
decltype(*begin)is very problematic:
- It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.
- You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.
- If the type is a proxy like with the dreaded
std::vector <bool>, hilarity ensues.
Consider taking advantage of the standard library, specifically
std::find ().C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
$endgroup$
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
return StackExchange.using("mathjaxEditing", function () {
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix) {
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
});
});
}, "mathjax-editing");
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "196"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216361%2fdetecting-if-an-element-is-found-inside-a-container%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
$begingroup$
Note that for functions the compiler will detect the template types based on the parameters.
So you can simply write:
bool test = is_contained(container.begin(), container.end(), anything);
I don't particularly like the use of decltype in your function. I would simply make it another template parameter.
template <typename Iterator, typename Value>
bool is_contained(Iterator begin, Iterator end, Value const& object);
Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).
answered 7 hours ago
Martin YorkMartin York
74k488271
$endgroup$
add a comment |
$begingroup$
Note that for functions the compiler will detect the template types based on the parameters.
So you can simply write:
bool test = is_contained(container.begin(), container.end(), anything);
I don't particularly like the use of decltype in your function. I would simply make it another template parameter.
template <typename Iterator, typename Value>
bool is_contained(Iterator begin, Iterator end, Value const& object);
Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).
answered 7 hours ago
Martin YorkMartin York
74k488271
$endgroup$
add a comment |
$begingroup$
Note that for functions the compiler will detect the template types based on the parameters.
So you can simply write:
bool test = is_contained(container.begin(), container.end(), anything);
I don't particularly like the use of decltype in your function. I would simply make it another template parameter.
template <typename Iterator, typename Value>
bool is_contained(Iterator begin, Iterator end, Value const& object);
Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).
answered 7 hours ago
Martin YorkMartin York
74k488271
$endgroup$
Note that for functions the compiler will detect the template types based on the parameters.
So you can simply write:
bool test = is_contained(container.begin(), container.end(), anything);
I don't particularly like the use of decltype in your function. I would simply make it another template parameter.
template <typename Iterator, typename Value>
bool is_contained(Iterator begin, Iterator end, Value const& object);
Because of the compiler deducing the names you can use any type. Also this is more flexable as it allows you to use any type that is comparable to the type inside the container (rather than only allowing values that are the same type (or trivial convertible)).
answered 7 hours ago
Martin YorkMartin York
74k488271
answered 7 hours ago
Martin YorkMartin York
74k488271
answered 7 hours ago
Martin YorkMartin York
74k488271
answered 7 hours ago
Martin YorkMartin York
74k488271
74k488271
add a comment |
add a comment |
$begingroup$
Do you want to test whether an element is in a container, or an iterator-range?
- The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.
- The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.
Constraining the needle to the type
decltype(*begin)is very problematic:
- It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.
- You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.
- If the type is a proxy like with the dreaded
std::vector <bool>, hilarity ensues.
Consider taking advantage of the standard library, specifically
std::find ().C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
$endgroup$
add a comment |
$begingroup$
Do you want to test whether an element is in a container, or an iterator-range?
- The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.
- The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.
Constraining the needle to the type
decltype(*begin)is very problematic:
- It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.
- You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.
- If the type is a proxy like with the dreaded
std::vector <bool>, hilarity ensues.
Consider taking advantage of the standard library, specifically
std::find ().C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
$endgroup$
add a comment |
$begingroup$
Do you want to test whether an element is in a container, or an iterator-range?
- The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.
- The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.
Constraining the needle to the type
decltype(*begin)is very problematic:
- It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.
- You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.
- If the type is a proxy like with the dreaded
std::vector <bool>, hilarity ensues.
Consider taking advantage of the standard library, specifically
std::find ().C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
$endgroup$
Do you want to test whether an element is in a container, or an iterator-range?
- The first allows for optimisation (taking advantage of the container's peculiarities). See "contains() algorithm for std::vector" for an example.
- The second is more general in the absence of any range-library, like the one expected for the C++20 standard, and available for earlier versions.
Constraining the needle to the type
decltype(*begin)is very problematic:
- It forces pass-by-value, which while it should be possible, at least with moveing, might be inefficient.
- You cannot take advantage of transparent comparators (a C++14 feature), forcing the creation of a useless temporary. On the flip-side, if transparent comparators are not used, only a single temporary is constructed.
- If the type is a proxy like with the dreaded
std::vector <bool>, hilarity ensues.
Consider taking advantage of the standard library, specifically
std::find ().C++ will deduce the function's template-arguments perfectly fine, no need for error-prone verbosity.
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
answered 6 hours ago
DeduplicatorDeduplicator
11.7k1950
11.7k1950
add a comment |
add a comment |
Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.
Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.
Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.
Daniel Duque is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to Code Review Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
Use MathJax to format equations. MathJax reference.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216361%2fdetecting-if-an-element-is-found-inside-a-container%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
