Btukfyl

I am trying to solve a problem in C#.

Here is the task:

• If a word begins with a vowel (a, e, i, o, u or A, E, I, O, U), remove
  the first letter and append it to the end, then add "che". If you have
  the word “orange” It translates to “rangeoche”


• If a word begins with a consonant (i.e. not a vowel), append "che" to the end of the word. For example, the word "chicken" becomes
  "chickenche".


• If the word has even number of letters append one more "e" to the end of it.

Print the translated sentence.

Example:

Hello there Amy

Output:

Helloche thereche myAche

Here is what I have done so far :

        string Sentence = Console.ReadLine();

        string output = Sentence.Split(' ');

        char letter;

        string che = "che";

        StringBuilder sb = new StringBuilder(Sentence);

        foreach (string s in output)

        {

            letter = s[0];



            if (letter == 'a' || letter == 'A' || letter == 'e' || letter == 'E' || letter == 'i'

            || letter == 'I' || letter == 'o' || letter == 'O' || letter == 'u' || letter == 'U')

            {

             //  Console.WriteLine("first char of the word is a vowel");

            }

            else

            {

                sb.Insert(s.Length,che);

              //  Console.WriteLine("first char of a word is a consonant");

            }



            if (s.Length % 2 == 0)

            {

              //  Console.WriteLine("the word has even numbers of letters");

            }

            //Console.WriteLine(firstchar);

            int currentWordLength = s.Length;



        }

        Console.WriteLine(sb);

The problem is I cannot add "che" or remove vowels of words because the index is moving due to those changes. I can only change the first word. My ifs are correct because if I uncomment the Console.Writelines they scan through each word.
I am just struggling with the adding/removing of each word. Can you please point me to the right direction?

I would suggest you to create StringBuilder object and append appropriate string into the IF condition. Try with the below code:

    string Sentence = Console.ReadLine();

    string output = Sentence.Split(' ');

    char letter;

    string che = "che";

    StringBuilder sb = null;

    Console.WriteLine("n");

    string strFinal = "";

    foreach (string s in output)

    {

        letter = s[0];

        sb = new StringBuilder(s);



        if (letter == 'a' || letter == 'A' || letter == 'e' || letter == 'E' || letter == 'i'

        || letter == 'I' || letter == 'o' || letter == 'O' || letter == 'u' || letter == 'U')

        {

            // Console.WriteLine("first char of the word is a vowel");

            string s1 = sb.Remove(0, 1).ToString();

            sb.Insert(s1.Length, letter);

            sb.Insert(sb.Length, che);

        }

        else

        {

            // Console.WriteLine("first char of a word is a consonant");

            sb.Insert(s.Length, che);

        }



        if (s.Length % 2 == 0)

        {

            // Console.WriteLine("the word has even numbers of letters");

            // sb.Insert(s.Length, "e");

            sb.Insert(sb.Length, "e");

        }

        //Console.WriteLine(firstchar);

        int currentWordLength = s.Length;



        strFinal += sb + " ";

    }



    Console.WriteLine(strFinal);

    Console.ReadKey();

First, I'd recommend changing your translation code to have a function that acts on words, instead of the whole sentence. So the code in foreach (string s in output) should be moved to another function that just acts on that string. And don't try to manipulate the string passed it, create a new one based on the logic you've listed. Once you've created the translated string, return it to the caller. The caller would then reconstruct the sentence from each returned translation.

You mustn't change your word before the end of ifs. you need to test all of the conditions and save the result in another values, finally do changes on the word:

foreach (string s in output)

    {

        letter = char.ToLower(s[0]);

        bool isVowel = false;

        bool isEven = false;



        if (letter == 'a' || letter == 'e' || letter == 'i'

         || letter == 'o' || letter == 'u')

        {

           isVowel = true;

        }            



        if (s.Length % 2 == 0)

        {

            isEven = true;

        }



        //Now you can change the word

        if (isVowel)

        {

            //Do What you want

        }



        if (isEven)

        {

            //Do What you want

        }



        //Console.WriteLine(firstchar);

        int currentWordLength = s.Length;



    }

Using the obvious extension methods:

public static class ExtensionMethods {

    // ***

    // *** int Extensions

    // ***

    public static bool IsEven(this int n) => n % 2 == 0;



    // ***

    // *** String Extensions

    // ***

    public static bool StartsWithOneOf(this string s, HashSet<char> starts) => starts.Contains(s[0]);

    public static string Join(this IEnumerable<string> strings, string sep) => String.Join(sep, strings);

}

You can use LINQ to process the rules:

var vowels = "aeiouAEIOU".ToHashSet();



var ans = src.Split(' ')

             .Select(w => (w.StartsWithOneOf(vowels) ? w.Substring(1)+w[0] : w)+"che"+(w.Length.IsEven() ? "e" : ""))

             .Join(" ");

Let's start from splitting the initial problem into smaller ones, with a help of extract methods:

  using using System.Text.RegularExpressions;



  ...



  private static String ConvertWord(string word) {

    //TODO: Solution here 

    return word; // <- Stub

  }



  private static String ConvertPhrase(string phrase) {

    // Regex (not Split) to preserve punctuation: 

    // we convert each word (continued sequence of letter A..Z a..z or ')

    // within the original phrase 

    return Regex.Replace(phrase, @"[A-Za-z']+", match => ConvertWord(match.Value));



    // Or if there's guarantee, that space is the only separator:

    // return string.Join(" ", phrase

    //   .Split(new char { ' ' }, StringSplitOptions.RemoveEmptyEntries) 

    //   .Select(item => ConvertWord(item)));

  }

Now it's time to implement ConvertWord:

  private static String ConvertWord(string word) {

    // Do not forget of special cases - e.g. empty string

    if (string.IsNullOrEmpty(word)) 

      return "chee";



    //  If the word has even number of letters append one more "e" to the end of it. 

    string suffix = word.Length % 2 == 0 ? "chee" : "che"; 



    // To cases: starting from vowel / consonant

    char letter = char.ToUpper(word[0]); 



    if (letter == 'A' || letter == 'E' || letter == 'I' || letter == 'O' || letter == 'U')

      return word.Substring(1) + word.Substring(0, 1) + suffix;

    else

      return word + suffix;

  }

Finally

  string Sentence = Console.ReadLine();



  Console.Write(ConvertPhrase(Sentence));

For test input

"It's just a simple test (demo only): nothing more!"

Will get

t'sIchee justchee ache simplechee testchee (demochee nlyochee): nothingche morechee!