Finding the amount of values within two numbers in python












0














Only started coding a few weeks ago but I've been having trouble seeing where I went wrong.



Goal is to write a function that takes a list of numbers as a parameter and returns the number of values that are within the numbers 24.54 & 47.54.



def count_in_range(x):

    sum = 0

    for i in x:

        if x > 24.54 and x < 47.54:

            sum = sum + 1

            return sum


Currently getting a "unorderable types: list() > float() error






python list numbers







share|improve this question


















  • 1




    if x > 24.54 and x < 47.54: should be if i > 24.54 and i < 47.54: because you are iterating the list of x with element i being retrieved.
    – MooingRawr
    Nov 22 at 20:39












  • Also, your return sum should be outside the loop.
    – John Anderson
    Nov 22 at 20:42










  • You would never have coded this bug with meaningful variable names. For example, list_of_numbers instead of x and number instead of i.
    – timgeb
    Nov 22 at 20:43












  • hmm that fixed the unorderable types error but now it's just returning an incorrect output
    – lume
    Nov 22 at 20:43










  • Did you read what John has to say about moving the return sum outside of the loop
    – MooingRawr
    Nov 22 at 20:44
















0














Only started coding a few weeks ago but I've been having trouble seeing where I went wrong.



Goal is to write a function that takes a list of numbers as a parameter and returns the number of values that are within the numbers 24.54 & 47.54.



def count_in_range(x):

    sum = 0

    for i in x:

        if x > 24.54 and x < 47.54:

            sum = sum + 1

            return sum


Currently getting a "unorderable types: list() > float() error






python list numbers







share|improve this question


















  • 1




    if x > 24.54 and x < 47.54: should be if i > 24.54 and i < 47.54: because you are iterating the list of x with element i being retrieved.
    – MooingRawr
    Nov 22 at 20:39












  • Also, your return sum should be outside the loop.
    – John Anderson
    Nov 22 at 20:42










  • You would never have coded this bug with meaningful variable names. For example, list_of_numbers instead of x and number instead of i.
    – timgeb
    Nov 22 at 20:43












  • hmm that fixed the unorderable types error but now it's just returning an incorrect output
    – lume
    Nov 22 at 20:43










  • Did you read what John has to say about moving the return sum outside of the loop
    – MooingRawr
    Nov 22 at 20:44














0












0








0







Only started coding a few weeks ago but I've been having trouble seeing where I went wrong.



Goal is to write a function that takes a list of numbers as a parameter and returns the number of values that are within the numbers 24.54 & 47.54.



def count_in_range(x):

    sum = 0

    for i in x:

        if x > 24.54 and x < 47.54:

            sum = sum + 1

            return sum


Currently getting a "unorderable types: list() > float() error






python list numbers







share|improve this question













Only started coding a few weeks ago but I've been having trouble seeing where I went wrong.



Goal is to write a function that takes a list of numbers as a parameter and returns the number of values that are within the numbers 24.54 & 47.54.



def count_in_range(x):

    sum = 0

    for i in x:

        if x > 24.54 and x < 47.54:

            sum = sum + 1

            return sum


Currently getting a "unorderable types: list() > float() error






python list numbers




python list numbers






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 22 at 20:38









lume

1




1








  • 1




    if x > 24.54 and x < 47.54: should be if i > 24.54 and i < 47.54: because you are iterating the list of x with element i being retrieved.
    – MooingRawr
    Nov 22 at 20:39












  • Also, your return sum should be outside the loop.
    – John Anderson
    Nov 22 at 20:42










  • You would never have coded this bug with meaningful variable names. For example, list_of_numbers instead of x and number instead of i.
    – timgeb
    Nov 22 at 20:43












  • hmm that fixed the unorderable types error but now it's just returning an incorrect output
    – lume
    Nov 22 at 20:43










  • Did you read what John has to say about moving the return sum outside of the loop
    – MooingRawr
    Nov 22 at 20:44














  • 1




    if x > 24.54 and x < 47.54: should be if i > 24.54 and i < 47.54: because you are iterating the list of x with element i being retrieved.
    – MooingRawr
    Nov 22 at 20:39












  • Also, your return sum should be outside the loop.
    – John Anderson
    Nov 22 at 20:42










  • You would never have coded this bug with meaningful variable names. For example, list_of_numbers instead of x and number instead of i.
    – timgeb
    Nov 22 at 20:43












  • hmm that fixed the unorderable types error but now it's just returning an incorrect output
    – lume
    Nov 22 at 20:43










  • Did you read what John has to say about moving the return sum outside of the loop
    – MooingRawr
    Nov 22 at 20:44








1




1




if x > 24.54 and x < 47.54: should be if i > 24.54 and i < 47.54: because you are iterating the list of x with element i being retrieved.
– MooingRawr
Nov 22 at 20:39






if x > 24.54 and x < 47.54: should be if i > 24.54 and i < 47.54: because you are iterating the list of x with element i being retrieved.
– MooingRawr
Nov 22 at 20:39














Also, your return sum should be outside the loop.
– John Anderson
Nov 22 at 20:42




Also, your return sum should be outside the loop.
– John Anderson
Nov 22 at 20:42












You would never have coded this bug with meaningful variable names. For example, list_of_numbers instead of x and number instead of i.
– timgeb
Nov 22 at 20:43






You would never have coded this bug with meaningful variable names. For example, list_of_numbers instead of x and number instead of i.
– timgeb
Nov 22 at 20:43














hmm that fixed the unorderable types error but now it's just returning an incorrect output
– lume
Nov 22 at 20:43




hmm that fixed the unorderable types error but now it's just returning an incorrect output
– lume
Nov 22 at 20:43












Did you read what John has to say about moving the return sum outside of the loop
– MooingRawr
Nov 22 at 20:44




Did you read what John has to say about moving the return sum outside of the loop
– MooingRawr
Nov 22 at 20:44












1 Answer
1






active

oldest

votes


















1














When you check the value of each item in the list, you're inadvertently checking the value of the entire list instead.



if x > 24.54 and x < 47.54:



should become



if i > 24.54 and x < 47.54:



because i is the variable that takes on the value of each item in the list as you iterate through.



Also, you want to move your return statement to outside the loop, otherwise the loop will terminate after 1 iteration.






share|improve this answer





















    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53437746%2ffinding-the-amount-of-values-within-two-numbers-in-python%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    1














    When you check the value of each item in the list, you're inadvertently checking the value of the entire list instead.



    if x > 24.54 and x < 47.54:



    should become



    if i > 24.54 and x < 47.54:



    because i is the variable that takes on the value of each item in the list as you iterate through.



    Also, you want to move your return statement to outside the loop, otherwise the loop will terminate after 1 iteration.






    share|improve this answer


























      1














      When you check the value of each item in the list, you're inadvertently checking the value of the entire list instead.



      if x > 24.54 and x < 47.54:



      should become



      if i > 24.54 and x < 47.54:



      because i is the variable that takes on the value of each item in the list as you iterate through.



      Also, you want to move your return statement to outside the loop, otherwise the loop will terminate after 1 iteration.






      share|improve this answer
























        1












        1








        1






        When you check the value of each item in the list, you're inadvertently checking the value of the entire list instead.



        if x > 24.54 and x < 47.54:



        should become



        if i > 24.54 and x < 47.54:



        because i is the variable that takes on the value of each item in the list as you iterate through.



        Also, you want to move your return statement to outside the loop, otherwise the loop will terminate after 1 iteration.






        share|improve this answer












        When you check the value of each item in the list, you're inadvertently checking the value of the entire list instead.



        if x > 24.54 and x < 47.54:



        should become



        if i > 24.54 and x < 47.54:



        because i is the variable that takes on the value of each item in the list as you iterate through.



        Also, you want to move your return statement to outside the loop, otherwise the loop will terminate after 1 iteration.







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 22 at 20:44









        theasianpianist

        8819




        8819






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid …



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid …



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53437746%2ffinding-the-amount-of-values-within-two-numbers-in-python%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            -

            Popular posts from this blog

            A CLEAN and SIMPLE way to add appendices to Table of Contents and bookmarks

            Image
            0 I found a lot of questions abount appendices and ToC. Many users want appendices to be grouped in an Appendix part, however some problems arise with ToC, hyperref, PDF viewer bookmarks, and so on. There are different solutions which require extra packages, command patching and other extra code, however none of them satisfies me. I almost found an easy way to accomplish a good result, where appendices are added to bookmarks in the right way and hyperref links point to the right page. However, the number of the "Appendix" part page is wrong (it's the number of appendix A). Is there any EASY way to fix that? This is a MWE: documentclass{book} usepackage[nottoc,notlot,notlof]{tocbibind} usepackage{hyperref} begin{document} frontmatter tableofcontents mainmatter part{First} chapter{...
            Read more

            Calculate evaluation metrics using cross_val_predict sklearn

            Image
            1 In the sklearn.model_selection.cross_val_predict page it is stated: Generate cross-validated estimates for each input data point. It is not appropriate to pass these predictions into an evaluation metric. Can someone explain what does it mean? If this gives estimate of Y (y prediction) for every Y (true Y), why can't I calculate metrics such as RMSE or coefficient of determination using these results? python scikit-learn cross-validation share | improve this question edited Nov 28 '18 at 17:52 desertnaut 20.3k 7 43 79 ...
            Read more

            Insert data from modal to MySQL (multiple modal on website)

            Image
            0 I have problem with inserting data to MySQL from modal. My modal: <a href="#" class="badge badge-pill badge-success">6 komentarzy</a> <a href="#" class="badge badge-pill badge-danger">brak komentarzy</a> <a data-toggle="modal" href="#add_desk_comm_{$desk_['desk_id']}" data-target="#add_desk_comm_{$desk_['desk_id']}" class="ediiit">(dodaj)</a> <div class="modal fade" id="add_desk_comm_{$desk_['desk_id']}" tabindex="-1" role="dialog" aria-labelledby="edit_printer" aria-hidden="true"> <div class="modal-dialog" role="document"> ...
            Read more