Btukfyl

I need to allow the user to enter a writing sample in the console or as a file and have my program split that input into a word vector (one word per item of vector). This is my current code:

while(cin >> inputString) {

    wordVector.push_back(inputString);

}

The trouble is, when I run this, it works fine until it reaches the end of the user's input. Then it seems to just endlessly loop.

inputString is type string.

wordVector is type string.

This is the full code: (the broken code is at the bottom)

#include <iostream>

#include <string>

#include <fstream>

#include <vector>

using namespace std;



// Debug message flag

const bool DEBUG = false;



// Prototypes

void splitToVectors(vector<string>&,vector<string>&,vector<int>&,int &);

double avSentLength(const vector<string>);

double avWordSyl(const vector<string>,const vector<char>);

double percentSentLong(const vector<int>,int);

int numSyllables(const vector<char>);

void nextScreen(int);



int main() {



    // Initialize variables and vectors

    bool validate;

    int characters,words,sentences = 0,syllables;

    string file;

    string inputString;

    char inputChar;

    int input;



    vector<string> wordVector;

    vector<char> charVector;

    vector<string> sentenceVector;

    vector<int> numWordsInSent;



    // Get writing sample

    do {



        // Request preferred location

        validate = true;

        cout << "Would you like to:" << endl;

        cout << "  1. Enter the writing sample in the console" << endl;

        cout << "  2. Read from a file" << endl << " > ";



        // Validate

        if(!(cin >> input)) { // This error checking condition functions as the cin

            validate = false;

            cin.clear();

            cin.ignore(100, 'n');

        }

        if((input < 1) || (input > 2)) {

            validate = false;

    }



    } while(!validate);





    // Transfer selected source to wordVector

    if(input == 1) {



        // Request sample

        cout << "Please enter the writing sample below:" << endl << endl;



        // Input sample

        while(cin >> inputString) {

            wordVector.push_back(inputString);

        }

    }

}

Are you sure you are hitting Ctrl-D to send the EOF properly? The following code seems to work:

int main()

{

    vector<string> words;

    std::string inputString;

    while (cin >> inputString)

    {

        words.push_back(inputString);

    }



    vector<string>::iterator it;

    for (it = words.begin(); it != words.end(); it++)

    {

        cout << *it << "n";

    }



    return 0;

}

I have not yet learned about iterators. So I came up with the following solution:
I use a getline to take all input and place into a string variable. I then have a for loop run through it, building a temporary string as it goes, until it encounters a space. When it sees a space, it adds the temporary variable to the vector, and resets the temporary variable. It continues this way until it reaches the end of the string.

In an interactive console/compiler while(cin >> inputString) will continue wait for user-input.

It may work on a non-interactive console/compiler that reads data from a static standard input. But it's worth noting that in (most conforming) interactive compilers, cin >> inputString will continue to wait for user input, and will (should) not evaluate to false until there occurs an error in reading input.

You may want to signal the program that input is finished. One way of doing this is to provide a keyword such as EOF which will break the while-loop (although the disadvantage of this is that you can't use EOF in the content of your input).