MVP - Presenter comparision: view injected in constructor vs takeView(View v) / dropView()
I've seen two approaches to MVP pattern in Android. Both are used in Android Architecture Blueprints:
public interface Contract {
interface View {
void showData(String data);
}
interface StartVersionPresenter {
void start();
}
interface DropViewVersionPresenter {
void takeView(View view);
void dropView();
}
}
1) The presenter in which the view is injected via the constructor:
public class StartVersionPresenter implements Contract.StartVersionPresenter {
private final Contract.View view;
private final Repository repository;
public StartVersionPresenter(Contract.View view, Repository repository) {
this.view = view;
this.repository = repository;
}
@Override
public void start() {
loadData();
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
view.showData(someData);
}
});
}
}
start() is called in onResume() Fragment's method.
2) The presenter in which the view is injected via the method (takeView in my example):
public class DropViewVersionPresenter implements Contract.DropViewVersionPresenter {
private final Repository repository;
private Contract.View view;
public DropViewVersionPresenter(Repository repository) {
this.repository = repository;
}
@Override
public void takeView(Contract.View view) {
this.view = view;
loadData();
}
@Override
public void dropView() {
view = null;
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
if (view != null)
view.showData(someData);
}
});
}
}
takeView(Contract.View view) is called in Fragment's onResume() method.
dropView() is called in Fragment's onDestroy() method.
In both cases the presenter is created in Fragment's onCreate() method.
Why does the second approach is used in more cases rather then the first one? I can see that the first one is simpler because we don't have to check that the view is not null if we want to call the method on it.
java
android dependency-injection mvp android-mvp asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
add a comment |
I've seen two approaches to MVP pattern in Android. Both are used in Android Architecture Blueprints:
public interface Contract {
interface View {
void showData(String data);
}
interface StartVersionPresenter {
void start();
}
interface DropViewVersionPresenter {
void takeView(View view);
void dropView();
}
}
1) The presenter in which the view is injected via the constructor:
public class StartVersionPresenter implements Contract.StartVersionPresenter {
private final Contract.View view;
private final Repository repository;
public StartVersionPresenter(Contract.View view, Repository repository) {
this.view = view;
this.repository = repository;
}
@Override
public void start() {
loadData();
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
view.showData(someData);
}
});
}
}
start() is called in onResume() Fragment's method.
2) The presenter in which the view is injected via the method (takeView in my example):
public class DropViewVersionPresenter implements Contract.DropViewVersionPresenter {
private final Repository repository;
private Contract.View view;
public DropViewVersionPresenter(Repository repository) {
this.repository = repository;
}
@Override
public void takeView(Contract.View view) {
this.view = view;
loadData();
}
@Override
public void dropView() {
view = null;
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
if (view != null)
view.showData(someData);
}
});
}
}
takeView(Contract.View view) is called in Fragment's onResume() method.
dropView() is called in Fragment's onDestroy() method.
In both cases the presenter is created in Fragment's onCreate() method.
Why does the second approach is used in more cases rather then the first one? I can see that the first one is simpler because we don't have to check that the view is not null if we want to call the method on it.
java
android dependency-injection mvp android-mvp asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
add a comment |
I've seen two approaches to MVP pattern in Android. Both are used in Android Architecture Blueprints:
public interface Contract {
interface View {
void showData(String data);
}
interface StartVersionPresenter {
void start();
}
interface DropViewVersionPresenter {
void takeView(View view);
void dropView();
}
}
1) The presenter in which the view is injected via the constructor:
public class StartVersionPresenter implements Contract.StartVersionPresenter {
private final Contract.View view;
private final Repository repository;
public StartVersionPresenter(Contract.View view, Repository repository) {
this.view = view;
this.repository = repository;
}
@Override
public void start() {
loadData();
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
view.showData(someData);
}
});
}
}
start() is called in onResume() Fragment's method.
2) The presenter in which the view is injected via the method (takeView in my example):
public class DropViewVersionPresenter implements Contract.DropViewVersionPresenter {
private final Repository repository;
private Contract.View view;
public DropViewVersionPresenter(Repository repository) {
this.repository = repository;
}
@Override
public void takeView(Contract.View view) {
this.view = view;
loadData();
}
@Override
public void dropView() {
view = null;
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
if (view != null)
view.showData(someData);
}
});
}
}
takeView(Contract.View view) is called in Fragment's onResume() method.
dropView() is called in Fragment's onDestroy() method.
In both cases the presenter is created in Fragment's onCreate() method.
Why does the second approach is used in more cases rather then the first one? I can see that the first one is simpler because we don't have to check that the view is not null if we want to call the method on it.
java
android dependency-injection mvp android-mvp asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
I've seen two approaches to MVP pattern in Android. Both are used in Android Architecture Blueprints:
public interface Contract {
interface View {
void showData(String data);
}
interface StartVersionPresenter {
void start();
}
interface DropViewVersionPresenter {
void takeView(View view);
void dropView();
}
}
1) The presenter in which the view is injected via the constructor:
public class StartVersionPresenter implements Contract.StartVersionPresenter {
private final Contract.View view;
private final Repository repository;
public StartVersionPresenter(Contract.View view, Repository repository) {
this.view = view;
this.repository = repository;
}
@Override
public void start() {
loadData();
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
view.showData(someData);
}
});
}
}
start() is called in onResume() Fragment's method.
2) The presenter in which the view is injected via the method (takeView in my example):
public class DropViewVersionPresenter implements Contract.DropViewVersionPresenter {
private final Repository repository;
private Contract.View view;
public DropViewVersionPresenter(Repository repository) {
this.repository = repository;
}
@Override
public void takeView(Contract.View view) {
this.view = view;
loadData();
}
@Override
public void dropView() {
view = null;
}
private void loadData() {
repository.getData(new DataCallback() {
@Override
public void onDataLoaded(String someData) {
if (view != null)
view.showData(someData);
}
});
}
}
takeView(Contract.View view) is called in Fragment's onResume() method.
dropView() is called in Fragment's onDestroy() method.
In both cases the presenter is created in Fragment's onCreate() method.
Why does the second approach is used in more cases rather then the first one? I can see that the first one is simpler because we don't have to check that the view is not null if we want to call the method on it.
java
android dependency-injection mvp android-mvp java
android dependency-injection mvp android-mvp asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
asked Nov 27 '18 at 20:46
AppiDevoAppiDevo
1,47621832
1,47621832
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53507883%2fmvp-presenter-comparision-view-injected-in-constructor-vs-takeviewview-v%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53507883%2fmvp-presenter-comparision-view-injected-in-constructor-vs-takeviewview-v%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
