What is an correct way to inject db context to Hangfire Recurring job?












1















I'm using HangFire to send emails to users in the background, regularly.



I'm obtaining email addresses from database, but I'm not sure whether I'm "injecting" database context to service that's responsible for sending emails correctly



This works correctly, is there a better way to do it?



public void Configure(IApplicationBuilder app, IHostingEnvironment env, Context context)
{
(...)

app.UseHangfireDashboard();
app.UseHangfireServer(new BackgroundJobServerOptions
{
HeartbeatInterval = new System.TimeSpan(0, 0, 5),
ServerCheckInterval = new System.TimeSpan(0, 0, 5),
SchedulePollingInterval = new System.TimeSpan(0, 0, 5)
});

RecurringJob.AddOrUpdate(() => new MessageService(context).Send(), Cron.Daily);

(...)
app.UseMvc();
}




public class MessageService
{
private Context ctx;

public MessageService(Context c)
{
ctx = c;
}

public void Send()
{
var emails = ctx.Users.Select(x => x.Email).ToList();

foreach (var email in emails)
{
sendEmail(email, "sample body");
}
}
}









share|improve this question



























    1















    I'm using HangFire to send emails to users in the background, regularly.



    I'm obtaining email addresses from database, but I'm not sure whether I'm "injecting" database context to service that's responsible for sending emails correctly



    This works correctly, is there a better way to do it?



    public void Configure(IApplicationBuilder app, IHostingEnvironment env, Context context)
    {
    (...)

    app.UseHangfireDashboard();
    app.UseHangfireServer(new BackgroundJobServerOptions
    {
    HeartbeatInterval = new System.TimeSpan(0, 0, 5),
    ServerCheckInterval = new System.TimeSpan(0, 0, 5),
    SchedulePollingInterval = new System.TimeSpan(0, 0, 5)
    });

    RecurringJob.AddOrUpdate(() => new MessageService(context).Send(), Cron.Daily);

    (...)
    app.UseMvc();
    }




    public class MessageService
    {
    private Context ctx;

    public MessageService(Context c)
    {
    ctx = c;
    }

    public void Send()
    {
    var emails = ctx.Users.Select(x => x.Email).ToList();

    foreach (var email in emails)
    {
    sendEmail(email, "sample body");
    }
    }
    }









    share|improve this question

























      1












      1








      1








      I'm using HangFire to send emails to users in the background, regularly.



      I'm obtaining email addresses from database, but I'm not sure whether I'm "injecting" database context to service that's responsible for sending emails correctly



      This works correctly, is there a better way to do it?



      public void Configure(IApplicationBuilder app, IHostingEnvironment env, Context context)
      {
      (...)

      app.UseHangfireDashboard();
      app.UseHangfireServer(new BackgroundJobServerOptions
      {
      HeartbeatInterval = new System.TimeSpan(0, 0, 5),
      ServerCheckInterval = new System.TimeSpan(0, 0, 5),
      SchedulePollingInterval = new System.TimeSpan(0, 0, 5)
      });

      RecurringJob.AddOrUpdate(() => new MessageService(context).Send(), Cron.Daily);

      (...)
      app.UseMvc();
      }




      public class MessageService
      {
      private Context ctx;

      public MessageService(Context c)
      {
      ctx = c;
      }

      public void Send()
      {
      var emails = ctx.Users.Select(x => x.Email).ToList();

      foreach (var email in emails)
      {
      sendEmail(email, "sample body");
      }
      }
      }









      share|improve this question














      I'm using HangFire to send emails to users in the background, regularly.



      I'm obtaining email addresses from database, but I'm not sure whether I'm "injecting" database context to service that's responsible for sending emails correctly



      This works correctly, is there a better way to do it?



      public void Configure(IApplicationBuilder app, IHostingEnvironment env, Context context)
      {
      (...)

      app.UseHangfireDashboard();
      app.UseHangfireServer(new BackgroundJobServerOptions
      {
      HeartbeatInterval = new System.TimeSpan(0, 0, 5),
      ServerCheckInterval = new System.TimeSpan(0, 0, 5),
      SchedulePollingInterval = new System.TimeSpan(0, 0, 5)
      });

      RecurringJob.AddOrUpdate(() => new MessageService(context).Send(), Cron.Daily);

      (...)
      app.UseMvc();
      }




      public class MessageService
      {
      private Context ctx;

      public MessageService(Context c)
      {
      ctx = c;
      }

      public void Send()
      {
      var emails = ctx.Users.Select(x => x.Email).ToList();

      foreach (var email in emails)
      {
      sendEmail(email, "sample body");
      }
      }
      }






      c# asp.net-core .net-core hangfire






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 28 '18 at 8:42









      JoeltyJoelty

      284111




      284111
























          2 Answers
          2






          active

          oldest

          votes


















          1














          Register repository via DI extension point of HF like this http://docs.hangfire.io/en/latest/background-methods/using-ioc-containers.html






          share|improve this answer
























          • Please provide the necessary parts in your answer. If the link breaks over time, your answer will become useless.

            – John
            Nov 28 '18 at 8:47











          • how is this even the answer

            – Seabizkit
            Dec 2 '18 at 5:41



















          0














          Definitely need to use DI (StructureMap or etc) for your issue. Please refactor your config file and decouple the "Context" class dependency from config class. Also introduce a container class to map DI classes (auto or manual).



          Create Container class



          Add container to Hangfire:



          GlobalConfiguration.Configuration.UseStructureMapActivator(Bootstrapper.Bootstrap());


          Also change job registration in config class:



          RecurringJob.AddOrUpdate<MessageService>(x => x.Send(), Cron.Daily);





          share|improve this answer























            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53515314%2fwhat-is-an-correct-way-to-inject-db-context-to-hangfire-recurring-job%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            2 Answers
            2






            active

            oldest

            votes








            2 Answers
            2






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            1














            Register repository via DI extension point of HF like this http://docs.hangfire.io/en/latest/background-methods/using-ioc-containers.html






            share|improve this answer
























            • Please provide the necessary parts in your answer. If the link breaks over time, your answer will become useless.

              – John
              Nov 28 '18 at 8:47











            • how is this even the answer

              – Seabizkit
              Dec 2 '18 at 5:41
















            1














            Register repository via DI extension point of HF like this http://docs.hangfire.io/en/latest/background-methods/using-ioc-containers.html






            share|improve this answer
























            • Please provide the necessary parts in your answer. If the link breaks over time, your answer will become useless.

              – John
              Nov 28 '18 at 8:47











            • how is this even the answer

              – Seabizkit
              Dec 2 '18 at 5:41














            1












            1








            1







            Register repository via DI extension point of HF like this http://docs.hangfire.io/en/latest/background-methods/using-ioc-containers.html






            share|improve this answer













            Register repository via DI extension point of HF like this http://docs.hangfire.io/en/latest/background-methods/using-ioc-containers.html







            share|improve this answer












            share|improve this answer



            share|improve this answer










            answered Nov 28 '18 at 8:44









            Rashid KhazievRashid Khaziev

            434




            434













            • Please provide the necessary parts in your answer. If the link breaks over time, your answer will become useless.

              – John
              Nov 28 '18 at 8:47











            • how is this even the answer

              – Seabizkit
              Dec 2 '18 at 5:41



















            • Please provide the necessary parts in your answer. If the link breaks over time, your answer will become useless.

              – John
              Nov 28 '18 at 8:47











            • how is this even the answer

              – Seabizkit
              Dec 2 '18 at 5:41

















            Please provide the necessary parts in your answer. If the link breaks over time, your answer will become useless.

            – John
            Nov 28 '18 at 8:47





            Please provide the necessary parts in your answer. If the link breaks over time, your answer will become useless.

            – John
            Nov 28 '18 at 8:47













            how is this even the answer

            – Seabizkit
            Dec 2 '18 at 5:41





            how is this even the answer

            – Seabizkit
            Dec 2 '18 at 5:41













            0














            Definitely need to use DI (StructureMap or etc) for your issue. Please refactor your config file and decouple the "Context" class dependency from config class. Also introduce a container class to map DI classes (auto or manual).



            Create Container class



            Add container to Hangfire:



            GlobalConfiguration.Configuration.UseStructureMapActivator(Bootstrapper.Bootstrap());


            Also change job registration in config class:



            RecurringJob.AddOrUpdate<MessageService>(x => x.Send(), Cron.Daily);





            share|improve this answer




























              0














              Definitely need to use DI (StructureMap or etc) for your issue. Please refactor your config file and decouple the "Context" class dependency from config class. Also introduce a container class to map DI classes (auto or manual).



              Create Container class



              Add container to Hangfire:



              GlobalConfiguration.Configuration.UseStructureMapActivator(Bootstrapper.Bootstrap());


              Also change job registration in config class:



              RecurringJob.AddOrUpdate<MessageService>(x => x.Send(), Cron.Daily);





              share|improve this answer


























                0












                0








                0







                Definitely need to use DI (StructureMap or etc) for your issue. Please refactor your config file and decouple the "Context" class dependency from config class. Also introduce a container class to map DI classes (auto or manual).



                Create Container class



                Add container to Hangfire:



                GlobalConfiguration.Configuration.UseStructureMapActivator(Bootstrapper.Bootstrap());


                Also change job registration in config class:



                RecurringJob.AddOrUpdate<MessageService>(x => x.Send(), Cron.Daily);





                share|improve this answer













                Definitely need to use DI (StructureMap or etc) for your issue. Please refactor your config file and decouple the "Context" class dependency from config class. Also introduce a container class to map DI classes (auto or manual).



                Create Container class



                Add container to Hangfire:



                GlobalConfiguration.Configuration.UseStructureMapActivator(Bootstrapper.Bootstrap());


                Also change job registration in config class:



                RecurringJob.AddOrUpdate<MessageService>(x => x.Send(), Cron.Daily);






                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Dec 2 '18 at 4:52









                Madawa IllesingheMadawa Illesinghe

                363




                363






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53515314%2fwhat-is-an-correct-way-to-inject-db-context-to-hangfire-recurring-job%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    A CLEAN and SIMPLE way to add appendices to Table of Contents and bookmarks

                    Calculate evaluation metrics using cross_val_predict sklearn

                    Insert data from modal to MySQL (multiple modal on website)