Btukfyl

I have some code that creates XML differently based on a very simple string of characters. Does anyone know why?

First of all, code snippet ( to clarify things for @mob ), with the lines AROUND the problem line:

my $XML = XML::Smart->new();



my $mylogin = {

    userId => $SQLUser,

    password => $SQLPass,

    maxIdle => '900000',

    properties => '<hidden for privacy concerns>'

};

$XML->{'System-Link'}{Login} = $mylogin;



my $request = {

    sessionHandle => '*current',

    workHandle => '*new',

    broker => 'EJB',

    maxIdle => '900000'

};

$XML->{'System-Link'}{Request} = $request;



my $querylist = {

    name => 'queryListPurchaseOrderItemRelease_SLTOKEN',

    domainClass => '<hidden for privacy concerns>',

    includeMetaData => 'true',

    maxReturned => '1'

};

$XML->{'System-Link'}{Request}{QueryList} = $querylist;

### PROBLEM LINE GOES HERE, just subsitute one of below lines here



## Muck with the DTD cause 'EMPTY' causes problems, this is an issue w/ the implementation of XML::Smart

open $dtd, '<', 'SystemLinkRequest.dtd';

my $dtdContent = do { local $/; <$dtd> };

close $dtd;

$dtdContent =~ s/EMPTY//g;



$XML->apply_dtd($dtdContent);



## Turn off output of DTD and meta tag generation

my $xmldata = $XML->data(nometagen => 1, nodtd => 1);

$xmldata =~ s/?>/?>n<!DOCTYPE System-Link SYSTEM 'SystemLinkRequest.dtd'>/m;

## Store a clean version (no passwords) in the local XML file

my $xmldata_clean = $xmldata;

$xmldata_clean =~ s/userIds*=s*"$SQLUser"s+passwords*=s*"$SQLPass"/userId="REMOVED" password="REMOVED"/g;



my $xml_filename = $RELEASE . "-" . time . ".xml";

print LOGF "{DEBUG} [" . localtime(time) . "] tBuilding XML Request COMPLETEDn";

print LOGF "{DEBUG} [" . localtime(time) . "] tWriting XML Request to Request_$xml_filename STARTEDn";



open $RequestLogfile, '>', "$logsDir/XML/Update/Request_$xml_filename";

print $RequestLogfile "n--------------- QUERY REQUEST ---------------n";

print $RequestLogfile $xmldata;

close $RequestLogfile;

Works:

$XML->{'System-Link'}{Request}{QueryList}{Pql} = "SELECT order,line,item,release,dueToDockDate,dueToStockDate,userFieldAmount1 WHERE (releaseStatus < '50' AND userFieldAmount1 = '$RELEASE' AND relatedQueryPurchaseOrder.orderStatus < '40' AND remainingQuantityForReleaseStockingUm > 0.000) ORDER BY order,line,release";

Does not work:

$XML->{'System-Link'}{Request}{QueryList}{Pql} = "SELECT order,line,item,release,dueToDockDate,dueToStockDate,userFieldAmount1 WHERE (releaseStatus < '50' AND userFieldAmount1 = '$RELEASE' AND relatedQueryPurchaseOrder.orderStatus < '40') ORDER BY order,line,release";

Now the XML I get.

Good XML ( Pql tag with CDATA ):

<QueryList domainClass="com.mapics.pm.PoItemRelease" includeMetaData="true" maxReturned="1" name="queryListPurchaseOrderItemRelease_SLTOKEN">

<Pql><![CDATA[SELECT order,line,item,release,dueToDockDate,dueToStockDate,userFieldAmount1 WHERE (releaseStatus < '50' AND userFieldAmount1 = '4001166' AND relatedQueryPurchaseOrder.orderStatus < '40' AND remainingQuantityForReleaseStockingUm > 0.000) ORDER BY order,line,release]]></Pql>

</QueryList>

Bad XML ( Pql attribute ):

<QueryList Pql="SELECT order,line,item,release,dueToDockDate,dueToStockDate,userFieldAmount1 WHERE (releaseStatus &lt; '50' AND userFieldAmount1 = '4001166' AND relatedQueryPurchaseOrder.orderStatus &lt; '40' ) ORDER BY order,line,release" domainClass="com.mapics.pm.PoItemRelease" includeMetaData="true" maxReturned="1" name="queryListPurchaseOrderItemRelease_SLTOKEN"/>

The only difference between the two lines of code is that the one that works has AND remainingQuantityForReleaseStockingUm > 0.000

So why does that impact the resulting XML?

XML::Smart::_data_type contains this code:

  return 3 if( $data && $data =~ /<.*?>/s    ) ;

where data type "3" indicates that the XML element should be rendered as CDATA. If that is the "good XML", it is only that way on accident.

I guess you could trick XML::Smart into rendering all your SQL queries as CDATA with an extra clause like

SELECT ... WHERE (... AND ... AND 1<>0) ORDER BY ...