VBA: looping around VLOOKUP to delete row on success












0















I am trying loop back over data in a worksheet in Excel 365 and when certain conditions are met, delete the row the condition applies to. All is well until I use the workbook VLookUp function as a part of the final condition - I need to delete the row if any of the conditions are true or if the VLookup is successful (an error in the VLookUp would mean that the row should be kept). What I currently have is:



On Error Resume Next

divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or _

       Condition2 Or _

       WorksheetFunction.VLookup(Cells(i, lcCol).Value, divRange, 1, False) Then

        If Err.Number = 0 Then

            Rows(i).Delete

        End If

   End If

Next i


The above flips to the other workbook (divWorkbook) and does not do what is intended. How would I keep focus on the current workbook and sheet and apply the delete when the vlookup is successful but not when it isn't?



Thanks,
Ben






excel vba excel-vba vlookup







share|improve this question

























  • Try specifying the worksheet you want to delete the rows from: ex: Worksheet("Sheet1").Rows(i).Delete

    – cybernetic.nomad
    Nov 26 '18 at 20:09











  • Thanks. I did make it more specific.

    – Ben
    Dec 1 '18 at 21:43
















0















I am trying loop back over data in a worksheet in Excel 365 and when certain conditions are met, delete the row the condition applies to. All is well until I use the workbook VLookUp function as a part of the final condition - I need to delete the row if any of the conditions are true or if the VLookup is successful (an error in the VLookUp would mean that the row should be kept). What I currently have is:



On Error Resume Next

divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or _

       Condition2 Or _

       WorksheetFunction.VLookup(Cells(i, lcCol).Value, divRange, 1, False) Then

        If Err.Number = 0 Then

            Rows(i).Delete

        End If

   End If

Next i


The above flips to the other workbook (divWorkbook) and does not do what is intended. How would I keep focus on the current workbook and sheet and apply the delete when the vlookup is successful but not when it isn't?



Thanks,
Ben






excel vba excel-vba vlookup







share|improve this question

























  • Try specifying the worksheet you want to delete the rows from: ex: Worksheet("Sheet1").Rows(i).Delete

    – cybernetic.nomad
    Nov 26 '18 at 20:09











  • Thanks. I did make it more specific.

    – Ben
    Dec 1 '18 at 21:43














0












0








0








I am trying loop back over data in a worksheet in Excel 365 and when certain conditions are met, delete the row the condition applies to. All is well until I use the workbook VLookUp function as a part of the final condition - I need to delete the row if any of the conditions are true or if the VLookup is successful (an error in the VLookUp would mean that the row should be kept). What I currently have is:



On Error Resume Next

divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or _

       Condition2 Or _

       WorksheetFunction.VLookup(Cells(i, lcCol).Value, divRange, 1, False) Then

        If Err.Number = 0 Then

            Rows(i).Delete

        End If

   End If

Next i


The above flips to the other workbook (divWorkbook) and does not do what is intended. How would I keep focus on the current workbook and sheet and apply the delete when the vlookup is successful but not when it isn't?



Thanks,
Ben






excel vba excel-vba vlookup







share|improve this question
















I am trying loop back over data in a worksheet in Excel 365 and when certain conditions are met, delete the row the condition applies to. All is well until I use the workbook VLookUp function as a part of the final condition - I need to delete the row if any of the conditions are true or if the VLookup is successful (an error in the VLookUp would mean that the row should be kept). What I currently have is:



On Error Resume Next

divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or _

       Condition2 Or _

       WorksheetFunction.VLookup(Cells(i, lcCol).Value, divRange, 1, False) Then

        If Err.Number = 0 Then

            Rows(i).Delete

        End If

   End If

Next i


The above flips to the other workbook (divWorkbook) and does not do what is intended. How would I keep focus on the current workbook and sheet and apply the delete when the vlookup is successful but not when it isn't?



Thanks,
Ben






excel vba excel-vba vlookup




excel vba excel-vba vlookup






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 27 '18 at 8:15









Pᴇʜ

22.8k62850




22.8k62850










asked Nov 26 '18 at 20:04









BenBen

196




196













  • Try specifying the worksheet you want to delete the rows from: ex: Worksheet("Sheet1").Rows(i).Delete

    – cybernetic.nomad
    Nov 26 '18 at 20:09











  • Thanks. I did make it more specific.

    – Ben
    Dec 1 '18 at 21:43



















  • Try specifying the worksheet you want to delete the rows from: ex: Worksheet("Sheet1").Rows(i).Delete

    – cybernetic.nomad
    Nov 26 '18 at 20:09











  • Thanks. I did make it more specific.

    – Ben
    Dec 1 '18 at 21:43

















Try specifying the worksheet you want to delete the rows from: ex: Worksheet("Sheet1").Rows(i).Delete

– cybernetic.nomad
Nov 26 '18 at 20:09





Try specifying the worksheet you want to delete the rows from: ex: Worksheet("Sheet1").Rows(i).Delete

– cybernetic.nomad
Nov 26 '18 at 20:09













Thanks. I did make it more specific.

– Ben
Dec 1 '18 at 21:43





Thanks. I did make it more specific.

– Ben
Dec 1 '18 at 21:43












1 Answer
1






active

oldest

votes


















2














I'd drop the On Error Resume Next and instead use Application.Match, testing the return value for an error.



Also, as noted by @cybernetic.nomad, be more explicit about what sheet you're working on.



Dim shtData As Worksheet



Set shtData = ActiveSheet ' or whatever



divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or Condition2 Or _

       Not IsError(Application.Match(shtData.Cells(i, lcCol).Value, divRange, 0)) Then



            shtData.Rows(i).Delete



   End If

Next i





share|improve this answer
























  • Thanks for your help. I fashioned the solution based on your response and it worked. I did add one line shtData.Activate in order to keep or at least return the focus to the current sheet.

    – Ben
    Dec 1 '18 at 21:47











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53488220%2fvba-looping-around-vlookup-to-delete-row-on-success%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









2














I'd drop the On Error Resume Next and instead use Application.Match, testing the return value for an error.



Also, as noted by @cybernetic.nomad, be more explicit about what sheet you're working on.



Dim shtData As Worksheet



Set shtData = ActiveSheet ' or whatever



divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or Condition2 Or _

       Not IsError(Application.Match(shtData.Cells(i, lcCol).Value, divRange, 0)) Then



            shtData.Rows(i).Delete



   End If

Next i





share|improve this answer
























  • Thanks for your help. I fashioned the solution based on your response and it worked. I did add one line shtData.Activate in order to keep or at least return the focus to the current sheet.

    – Ben
    Dec 1 '18 at 21:47
















2














I'd drop the On Error Resume Next and instead use Application.Match, testing the return value for an error.



Also, as noted by @cybernetic.nomad, be more explicit about what sheet you're working on.



Dim shtData As Worksheet



Set shtData = ActiveSheet ' or whatever



divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or Condition2 Or _

       Not IsError(Application.Match(shtData.Cells(i, lcCol).Value, divRange, 0)) Then



            shtData.Rows(i).Delete



   End If

Next i





share|improve this answer
























  • Thanks for your help. I fashioned the solution based on your response and it worked. I did add one line shtData.Activate in order to keep or at least return the focus to the current sheet.

    – Ben
    Dec 1 '18 at 21:47














2












2








2







I'd drop the On Error Resume Next and instead use Application.Match, testing the return value for an error.



Also, as noted by @cybernetic.nomad, be more explicit about what sheet you're working on.



Dim shtData As Worksheet



Set shtData = ActiveSheet ' or whatever



divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or Condition2 Or _

       Not IsError(Application.Match(shtData.Cells(i, lcCol).Value, divRange, 0)) Then



            shtData.Rows(i).Delete



   End If

Next i





share|improve this answer













I'd drop the On Error Resume Next and instead use Application.Match, testing the return value for an error.



Also, as noted by @cybernetic.nomad, be more explicit about what sheet you're working on.



Dim shtData As Worksheet



Set shtData = ActiveSheet ' or whatever



divFile = "C:....workbook.xlsx"

Set divWorkbook = Workbooks.Open(divFile)

Set divRange = divWorkbook.Worksheets("Sheet3").Range("B2:B274")



For i = lastRow To firstDataRow Step -1

    If Condition1 Or Condition2 Or _

       Not IsError(Application.Match(shtData.Cells(i, lcCol).Value, divRange, 0)) Then



            shtData.Rows(i).Delete



   End If

Next i






share|improve this answer












share|improve this answer



share|improve this answer










answered Nov 26 '18 at 20:47









Tim WilliamsTim Williams

87k97086




87k97086













  • Thanks for your help. I fashioned the solution based on your response and it worked. I did add one line shtData.Activate in order to keep or at least return the focus to the current sheet.

    – Ben
    Dec 1 '18 at 21:47



















  • Thanks for your help. I fashioned the solution based on your response and it worked. I did add one line shtData.Activate in order to keep or at least return the focus to the current sheet.

    – Ben
    Dec 1 '18 at 21:47

















Thanks for your help. I fashioned the solution based on your response and it worked. I did add one line shtData.Activate in order to keep or at least return the focus to the current sheet.

– Ben
Dec 1 '18 at 21:47





Thanks for your help. I fashioned the solution based on your response and it worked. I did add one line shtData.Activate in order to keep or at least return the focus to the current sheet.

– Ben
Dec 1 '18 at 21:47




















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid …



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53488220%2fvba-looping-around-vlookup-to-delete-row-on-success%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







-

Popular posts from this blog

Contact image not getting when fetch all contact list from iPhone by CNContact

Image
up vote 0 down vote favorite I know this question already asked but not getting solution. From this code I will get all the information from the contact but image not found when open vcf files on mac os, also not getting when share this file. I use this stackoverflow link here but It's not help full. var contacts = [CNContact]() let keys = [CNContactVCardSerialization.descriptorForRequiredKeys() ] as [Any] let request = CNContactFetchRequest(keysToFetch: keys as! [CNKeyDescriptor]) do { try self.contactStore.enumerateContacts(with: request) { (contact, stop) in // Array containing all unified contacts from everywhere contacts.append(contact) } } catch { print("unable to fetch contacts") } do { let data = try
Read more

count number of partitions of a set with n elements into k subsets

Image
up vote 6 down vote favorite 1 This program is for count number of partitions of a set with n elements into k subsets I am confusing here return k*countP(n-1, k) + countP(n-1, k-1); can some one explain what is happening here? why we are multiplying with k? NOTE->I know this is not the best way to calculate number of partitions that would be DP // A C++ program to count number of partitions // of a set with n elements into k subsets #include<iostream> using namespace std; // Returns count of different partitions of n // elements in k subsets int countP(int n, int k) { // Base cases if (n == 0 || k == 0 || k > n) return 0; if (k == 1 || k == n) return 1; // S(n+1, k) = k*S(n, k) + S(n, k-1) return k*countP(n-1, k) + countP(n-1, k-1); } // Driver program int ma
Read more

A CLEAN and SIMPLE way to add appendices to Table of Contents and bookmarks

Image
0 I found a lot of questions abount appendices and ToC. Many users want appendices to be grouped in an Appendix part, however some problems arise with ToC, hyperref, PDF viewer bookmarks, and so on. There are different solutions which require extra packages, command patching and other extra code, however none of them satisfies me. I almost found an easy way to accomplish a good result, where appendices are added to bookmarks in the right way and hyperref links point to the right page. However, the number of the "Appendix" part page is wrong (it's the number of appendix A). Is there any EASY way to fix that? This is a MWE: documentclass{book} usepackage[nottoc,notlot,notlof]{tocbibind} usepackage{hyperref} begin{document} frontmatter tableofcontents mainmatter part{First} chapter{
Read more