Adding a “%” to a route using React-Router causes the app to crash
I'm using react-router-dom. I've found that when a user modifies the querystring of the current page to add a final "%", the app crashes and the following error is printed in the console:
URIError: Pathname "/search%" could not be decoded. This is likely caused by an invalid percent-encoding
I've found in their GitHub repository that the error is related to some issue they have with the history dependency, but not fix for it.
Does anyone know what can be done about it? I don't seem to find a way to take control over the parsing of the URL.
Thanks.
reactjs react-router-dom
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
add a comment |
I'm using react-router-dom. I've found that when a user modifies the querystring of the current page to add a final "%", the app crashes and the following error is printed in the console:
URIError: Pathname "/search%" could not be decoded. This is likely caused by an invalid percent-encoding
I've found in their GitHub repository that the error is related to some issue they have with the history dependency, but not fix for it.
Does anyone know what can be done about it? I don't seem to find a way to take control over the parsing of the URL.
Thanks.
reactjs react-router-dom
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
1
what's the real problem here, you want to remove the "%" from the url or do you want to encode it? What does "when a user modifies the query string" mean, are your users supposed to write the url's themselves?
– Velimir Tchatchevsky
Nov 27 '18 at 17:48
@VelimirTchatchevsky they are not supposed to, but they can, and we'd like to be able to handle the error in that case instead of letting the app crash
– Heathcliff
Nov 27 '18 at 18:05
1
In my personal opinion that's an overkill, if the user is purposefully misusing the application you shoudn't care about the state he ends up in - besides covering any security concerns of course. Otherwise you can handle incorrect links with a rewrite rule from your server I guess.
– Velimir Tchatchevsky
Nov 27 '18 at 18:12
add a comment |
I'm using react-router-dom. I've found that when a user modifies the querystring of the current page to add a final "%", the app crashes and the following error is printed in the console:
URIError: Pathname "/search%" could not be decoded. This is likely caused by an invalid percent-encoding
I've found in their GitHub repository that the error is related to some issue they have with the history dependency, but not fix for it.
Does anyone know what can be done about it? I don't seem to find a way to take control over the parsing of the URL.
Thanks.
reactjs react-router-dom
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
I'm using react-router-dom. I've found that when a user modifies the querystring of the current page to add a final "%", the app crashes and the following error is printed in the console:
URIError: Pathname "/search%" could not be decoded. This is likely caused by an invalid percent-encoding
I've found in their GitHub repository that the error is related to some issue they have with the history dependency, but not fix for it.
Does anyone know what can be done about it? I don't seem to find a way to take control over the parsing of the URL.
Thanks.
reactjs react-router-dom
reactjs react-router-dom
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
asked Nov 27 '18 at 17:45
HeathcliffHeathcliff
95631128
95631128
1
what's the real problem here, you want to remove the "%" from the url or do you want to encode it? What does "when a user modifies the query string" mean, are your users supposed to write the url's themselves?
– Velimir Tchatchevsky
Nov 27 '18 at 17:48
@VelimirTchatchevsky they are not supposed to, but they can, and we'd like to be able to handle the error in that case instead of letting the app crash
– Heathcliff
Nov 27 '18 at 18:05
1
In my personal opinion that's an overkill, if the user is purposefully misusing the application you shoudn't care about the state he ends up in - besides covering any security concerns of course. Otherwise you can handle incorrect links with a rewrite rule from your server I guess.
– Velimir Tchatchevsky
Nov 27 '18 at 18:12
add a comment |
1
what's the real problem here, you want to remove the "%" from the url or do you want to encode it? What does "when a user modifies the query string" mean, are your users supposed to write the url's themselves?
– Velimir Tchatchevsky
Nov 27 '18 at 17:48
@VelimirTchatchevsky they are not supposed to, but they can, and we'd like to be able to handle the error in that case instead of letting the app crash
– Heathcliff
Nov 27 '18 at 18:05
1
In my personal opinion that's an overkill, if the user is purposefully misusing the application you shoudn't care about the state he ends up in - besides covering any security concerns of course. Otherwise you can handle incorrect links with a rewrite rule from your server I guess.
– Velimir Tchatchevsky
Nov 27 '18 at 18:12
1
1
what's the real problem here, you want to remove the "%" from the url or do you want to encode it? What does "when a user modifies the query string" mean, are your users supposed to write the url's themselves?
– Velimir Tchatchevsky
Nov 27 '18 at 17:48
what's the real problem here, you want to remove the "%" from the url or do you want to encode it? What does "when a user modifies the query string" mean, are your users supposed to write the url's themselves?
– Velimir Tchatchevsky
Nov 27 '18 at 17:48
@VelimirTchatchevsky they are not supposed to, but they can, and we'd like to be able to handle the error in that case instead of letting the app crash
– Heathcliff
Nov 27 '18 at 18:05
@VelimirTchatchevsky they are not supposed to, but they can, and we'd like to be able to handle the error in that case instead of letting the app crash
– Heathcliff
Nov 27 '18 at 18:05
1
1
In my personal opinion that's an overkill, if the user is purposefully misusing the application you shoudn't care about the state he ends up in - besides covering any security concerns of course. Otherwise you can handle incorrect links with a rewrite rule from your server I guess.
– Velimir Tchatchevsky
Nov 27 '18 at 18:12
In my personal opinion that's an overkill, if the user is purposefully misusing the application you shoudn't care about the state he ends up in - besides covering any security concerns of course. Otherwise you can handle incorrect links with a rewrite rule from your server I guess.
– Velimir Tchatchevsky
Nov 27 '18 at 18:12
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53505311%2fadding-a-to-a-route-using-react-router-causes-the-app-to-crash%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53505311%2fadding-a-to-a-route-using-react-router-causes-the-app-to-crash%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
what's the real problem here, you want to remove the "%" from the url or do you want to encode it? What does "when a user modifies the query string" mean, are your users supposed to write the url's themselves?
– Velimir Tchatchevsky
Nov 27 '18 at 17:48
@VelimirTchatchevsky they are not supposed to, but they can, and we'd like to be able to handle the error in that case instead of letting the app crash
– Heathcliff
Nov 27 '18 at 18:05
1
In my personal opinion that's an overkill, if the user is purposefully misusing the application you shoudn't care about the state he ends up in - besides covering any security concerns of course. Otherwise you can handle incorrect links with a rewrite rule from your server I guess.
– Velimir Tchatchevsky
Nov 27 '18 at 18:12