Incorrect JSS style order - Material-UI
I have a situation the JSS styles of my MUI component library (Styles A) are superceding those provided by a consumer's website (Styles B).
Styles A is intended to overwritable by Styles B.
Take this minimal example:
Styles A (in Component Library)
const styles = theme => ({
title: {
color: 'red'
}
});
const CollapsibleCard = ({classes, title}) => (
<Typography className={classes.title} variant={"h6"}>
{title}
</Typography>
);
export default withStyles(styles)(CollapsibleCard);
Styles B (in Consumer site)
const styles = {
title: {
color: 'green'
},
};
const Page = ({classes}) => (
<CollapsibleCard
title={"Testing"}
classes={{
title: classes.title
}}
/>
);
export default withStyles(styles)(Page);
Resulting in the element having a cascading style of:
.CollapsibleCard-title-160 {
color: red;
}
.Page-title-157 {
color: green;
}
Where green from Styles B is being overwritten by red from Styles A.
Edit: The reason behind this order appears to be the order in which MUI (specifically the withStyle() function) injects stylesheets.
While this can be fixed (as noted here) by passing an index in the withStyles options, i.e: export default withStyles(styles, {index: 1})(Page);. This doesn't seem to be the most efficient/effective approach in a library context.
Is there a way to dictate the order of the MUI styles < Component Library styles < Consumer styles without declaring the index for each withStyles?
reactjs themes material-ui jss css-in-js
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
add a comment |
I have a situation the JSS styles of my MUI component library (Styles A) are superceding those provided by a consumer's website (Styles B).
Styles A is intended to overwritable by Styles B.
Take this minimal example:
Styles A (in Component Library)
const styles = theme => ({
title: {
color: 'red'
}
});
const CollapsibleCard = ({classes, title}) => (
<Typography className={classes.title} variant={"h6"}>
{title}
</Typography>
);
export default withStyles(styles)(CollapsibleCard);
Styles B (in Consumer site)
const styles = {
title: {
color: 'green'
},
};
const Page = ({classes}) => (
<CollapsibleCard
title={"Testing"}
classes={{
title: classes.title
}}
/>
);
export default withStyles(styles)(Page);
Resulting in the element having a cascading style of:
.CollapsibleCard-title-160 {
color: red;
}
.Page-title-157 {
color: green;
}
Where green from Styles B is being overwritten by red from Styles A.
Edit: The reason behind this order appears to be the order in which MUI (specifically the withStyle() function) injects stylesheets.
While this can be fixed (as noted here) by passing an index in the withStyles options, i.e: export default withStyles(styles, {index: 1})(Page);. This doesn't seem to be the most efficient/effective approach in a library context.
Is there a way to dictate the order of the MUI styles < Component Library styles < Consumer styles without declaring the index for each withStyles?
reactjs themes material-ui jss css-in-js
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
add a comment |
I have a situation the JSS styles of my MUI component library (Styles A) are superceding those provided by a consumer's website (Styles B).
Styles A is intended to overwritable by Styles B.
Take this minimal example:
Styles A (in Component Library)
const styles = theme => ({
title: {
color: 'red'
}
});
const CollapsibleCard = ({classes, title}) => (
<Typography className={classes.title} variant={"h6"}>
{title}
</Typography>
);
export default withStyles(styles)(CollapsibleCard);
Styles B (in Consumer site)
const styles = {
title: {
color: 'green'
},
};
const Page = ({classes}) => (
<CollapsibleCard
title={"Testing"}
classes={{
title: classes.title
}}
/>
);
export default withStyles(styles)(Page);
Resulting in the element having a cascading style of:
.CollapsibleCard-title-160 {
color: red;
}
.Page-title-157 {
color: green;
}
Where green from Styles B is being overwritten by red from Styles A.
Edit: The reason behind this order appears to be the order in which MUI (specifically the withStyle() function) injects stylesheets.
While this can be fixed (as noted here) by passing an index in the withStyles options, i.e: export default withStyles(styles, {index: 1})(Page);. This doesn't seem to be the most efficient/effective approach in a library context.
Is there a way to dictate the order of the MUI styles < Component Library styles < Consumer styles without declaring the index for each withStyles?
reactjs themes material-ui jss css-in-js
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
I have a situation the JSS styles of my MUI component library (Styles A) are superceding those provided by a consumer's website (Styles B).
Styles A is intended to overwritable by Styles B.
Take this minimal example:
Styles A (in Component Library)
const styles = theme => ({
title: {
color: 'red'
}
});
const CollapsibleCard = ({classes, title}) => (
<Typography className={classes.title} variant={"h6"}>
{title}
</Typography>
);
export default withStyles(styles)(CollapsibleCard);
Styles B (in Consumer site)
const styles = {
title: {
color: 'green'
},
};
const Page = ({classes}) => (
<CollapsibleCard
title={"Testing"}
classes={{
title: classes.title
}}
/>
);
export default withStyles(styles)(Page);
Resulting in the element having a cascading style of:
.CollapsibleCard-title-160 {
color: red;
}
.Page-title-157 {
color: green;
}
Where green from Styles B is being overwritten by red from Styles A.
Edit: The reason behind this order appears to be the order in which MUI (specifically the withStyle() function) injects stylesheets.
While this can be fixed (as noted here) by passing an index in the withStyles options, i.e: export default withStyles(styles, {index: 1})(Page);. This doesn't seem to be the most efficient/effective approach in a library context.
Is there a way to dictate the order of the MUI styles < Component Library styles < Consumer styles without declaring the index for each withStyles?
reactjs themes material-ui jss css-in-js
reactjs themes material-ui jss css-in-js
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
edited Nov 28 '18 at 22:17
Ryan Achten
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
asked Nov 28 '18 at 1:48
Ryan AchtenRyan Achten
181212
181212
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53510888%2fincorrect-jss-style-order-material-ui%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53510888%2fincorrect-jss-style-order-material-ui%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
