Angular Dynamic Component Change Detection Not Working












1















I am having an issue getting my dynamic Angular components to trigger change detection.



I was trying to following https://juristr.com/blog/2017/11/dynamic-angular-components-for-rendering-html/ this tutorial. I was successful in getting dynamic components to show up (yes I am also using leaflet). However when I want to update a component (popup) and i use the following lines of code (below) this "data" field does get updated with new values but the component never updates the values on the view. Any help with this would be appreciated.



updateIcon(markerLayer, color, i, sign?) {
console.log('icon updates');
const newNbOffset = this.elccMapLogicService.getPopupOffset(i, this.currentPopupOffset);
const newIcon = L.icon({
iconSize: [this.currentMarkerSize, this.currentMarkerSize],
iconAnchor: this.currentIconOffset,
iconUrl: 'assets/map_features/markers/sign-' + color + '.png',
popupAnchor: [-newNbOffset[0], newNbOffset[1]]
});
markerLayer.setIcon(newIcon);
if (sign) {
this.northBoundMarkerComponents.forEach(component => {
if (sign.plazaId === component.id) {

component.componentInstance.data = sign;

component.componentInstance.instance.cd.detectChanges();
}
});
}
markerLayer.getPopup().update();
}









share|improve this question























  • Hi James, could you produce a Minimal, Complete, and Verifiable example in something like StackBlitz?

    – Narm
    Nov 28 '18 at 1:43
















1















I am having an issue getting my dynamic Angular components to trigger change detection.



I was trying to following https://juristr.com/blog/2017/11/dynamic-angular-components-for-rendering-html/ this tutorial. I was successful in getting dynamic components to show up (yes I am also using leaflet). However when I want to update a component (popup) and i use the following lines of code (below) this "data" field does get updated with new values but the component never updates the values on the view. Any help with this would be appreciated.



updateIcon(markerLayer, color, i, sign?) {
console.log('icon updates');
const newNbOffset = this.elccMapLogicService.getPopupOffset(i, this.currentPopupOffset);
const newIcon = L.icon({
iconSize: [this.currentMarkerSize, this.currentMarkerSize],
iconAnchor: this.currentIconOffset,
iconUrl: 'assets/map_features/markers/sign-' + color + '.png',
popupAnchor: [-newNbOffset[0], newNbOffset[1]]
});
markerLayer.setIcon(newIcon);
if (sign) {
this.northBoundMarkerComponents.forEach(component => {
if (sign.plazaId === component.id) {

component.componentInstance.data = sign;

component.componentInstance.instance.cd.detectChanges();
}
});
}
markerLayer.getPopup().update();
}









share|improve this question























  • Hi James, could you produce a Minimal, Complete, and Verifiable example in something like StackBlitz?

    – Narm
    Nov 28 '18 at 1:43














1












1








1








I am having an issue getting my dynamic Angular components to trigger change detection.



I was trying to following https://juristr.com/blog/2017/11/dynamic-angular-components-for-rendering-html/ this tutorial. I was successful in getting dynamic components to show up (yes I am also using leaflet). However when I want to update a component (popup) and i use the following lines of code (below) this "data" field does get updated with new values but the component never updates the values on the view. Any help with this would be appreciated.



updateIcon(markerLayer, color, i, sign?) {
console.log('icon updates');
const newNbOffset = this.elccMapLogicService.getPopupOffset(i, this.currentPopupOffset);
const newIcon = L.icon({
iconSize: [this.currentMarkerSize, this.currentMarkerSize],
iconAnchor: this.currentIconOffset,
iconUrl: 'assets/map_features/markers/sign-' + color + '.png',
popupAnchor: [-newNbOffset[0], newNbOffset[1]]
});
markerLayer.setIcon(newIcon);
if (sign) {
this.northBoundMarkerComponents.forEach(component => {
if (sign.plazaId === component.id) {

component.componentInstance.data = sign;

component.componentInstance.instance.cd.detectChanges();
}
});
}
markerLayer.getPopup().update();
}









share|improve this question














I am having an issue getting my dynamic Angular components to trigger change detection.



I was trying to following https://juristr.com/blog/2017/11/dynamic-angular-components-for-rendering-html/ this tutorial. I was successful in getting dynamic components to show up (yes I am also using leaflet). However when I want to update a component (popup) and i use the following lines of code (below) this "data" field does get updated with new values but the component never updates the values on the view. Any help with this would be appreciated.



updateIcon(markerLayer, color, i, sign?) {
console.log('icon updates');
const newNbOffset = this.elccMapLogicService.getPopupOffset(i, this.currentPopupOffset);
const newIcon = L.icon({
iconSize: [this.currentMarkerSize, this.currentMarkerSize],
iconAnchor: this.currentIconOffset,
iconUrl: 'assets/map_features/markers/sign-' + color + '.png',
popupAnchor: [-newNbOffset[0], newNbOffset[1]]
});
markerLayer.setIcon(newIcon);
if (sign) {
this.northBoundMarkerComponents.forEach(component => {
if (sign.plazaId === component.id) {

component.componentInstance.data = sign;

component.componentInstance.instance.cd.detectChanges();
}
});
}
markerLayer.getPopup().update();
}






angular leaflet






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 28 '18 at 0:06









James MakJames Mak

739




739













  • Hi James, could you produce a Minimal, Complete, and Verifiable example in something like StackBlitz?

    – Narm
    Nov 28 '18 at 1:43



















  • Hi James, could you produce a Minimal, Complete, and Verifiable example in something like StackBlitz?

    – Narm
    Nov 28 '18 at 1:43

















Hi James, could you produce a Minimal, Complete, and Verifiable example in something like StackBlitz?

– Narm
Nov 28 '18 at 1:43





Hi James, could you produce a Minimal, Complete, and Verifiable example in something like StackBlitz?

– Narm
Nov 28 '18 at 1:43












0






active

oldest

votes











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53510134%2fangular-dynamic-component-change-detection-not-working%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53510134%2fangular-dynamic-component-change-detection-not-working%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Lallio

Unable to find Lightning Node

Futebolista